Add Key::Cut, Key::Copy, Key::Paste
#3725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the proposed solution makes sense: we translate the special keys to |
MarijnS95
force-pushed
the
egui-winit-handle-dedicated-cut-copy-paste-keys
branch
2 times, most recently
from
077cce2
to
c84f88a
Compare
|
Okay, added the necessary |
The comment added in commit 8a0bc97 ("[egui_glium] Fix paste") seems to assume that `winit` "should have translated" common "paste" keyboard combos to a `Cut`/`Copy`/`Paste` "KeyCode", but completely glossed over the fact that this `KeyCode` (now also `NamedKey`) maps to a special key dedicated to this purpose found on some keyboards and OSes. Make sure that this key is still handled in addition to the combo that is detected.
MarijnS95
force-pushed
the
egui-winit-handle-dedicated-cut-copy-paste-keys
branch
from
c84f88a
to
6f097ea
Compare
emilk
approved these changes
Dec 25, 2023
emilk
changed the title
Cut, Copy and Paste commandsKey::Cut, Key::Copy, Key::Paste
MarijnS95
deleted the
egui-winit-handle-dedicated-cut-copy-paste-keys
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment added in commit 8a0bc97 ("[egui_glium] Fix paste") seems to assume that
winit"should have translated" common "paste" keyboard combos to aCut/Copy/Paste"KeyCode", but completely glossed over the fact that thisKeyCode(now alsoNamedKey) maps to a special key dedicated to this purpose found on some keyboards and OSes. Make sure that this key is still handled in addition to the combo that is detected.Note that this PR does not compile as it is (and I have hence not tested this nor even ran into this limitation), just noticed this inconsistency while failing to understand a code comment. We'd have to decide if the variants should be added to
egui::Keyor if these helper functions need to takewinitkeys (ScanCodeorNamedKey) directly?I should have an old keyboard with a physical paste key in a drawer somewhere. And on Android there are special copy/paste events that can be sent by a virtual keyboard or the debug shell, so that this can be properly tested before it is merged.
(Except that the current
clipboardimplementation is not supported on Android)